Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] Fix compact table style to avoid outputting a leading space#44915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedJan 5, 2022
no change to the testsuite ? this looks suspicious to me |
Seldaek commentedJan 5, 2022
I'll fix the tests if this is acceptable. Sorry but don't want to waste time on that if it's going to be closed due to being seen as BC break. |
fabpot commentedJan 9, 2022
That works for me! Please, go ahead with the tests :) |
fabpot commentedFeb 25, 2022
@Seldaek Any news? |
Seldaek commentedMar 16, 2022
Sorry, got lost in the inbox.. Rebased and fixed TableTest now. |
chalasr commentedMar 16, 2022
Thank you@Seldaek. |
This changes the
compactoutput from:To:
Note the only difference is the leading space which is not there anymore.
IMO this is a much better default, but I do understand it changes something which has been as it is for ages, which may be considered a BC break more than a bugfix.