Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add visibility context option in PropertyNormalizer#44902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alamirault
Copy link
Contributor

@alamiraultalamirault commentedJan 3, 2022•
edited
Loading

QA
Branch?6.2
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#39143
LicenseMIT
Doc PRsymfony/symfony-docs#...

This PR is an attempt tofix#39143 request.
It allows to control which object property visibility we want to normalize. By defaut publuc, protected and private properties are normalized but sometime only public are enough

if it's ok for you, I will create PR for docs

chojnicki and christian-kolb reacted with thumbs up emoji
@carsonbotcarsonbot added this to the6.1 milestoneJan 3, 2022
@alamiraultalamirault changed the titleAdd visibility context option in PropertyNormalizer[Serializer] Add visibility context option in PropertyNormalizerJan 3, 2022
@carsonbot
Copy link

Hey!

I think@alexandre-daubois has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Serializer] Add visibility context option in PropertyNormalizerAdd visibility context option in PropertyNormalizerMay 10, 2022
@fabpotfabpot modified the milestones:6.1,6.2May 20, 2022
@alamirault
Copy link
ContributorAuthor

alamirault commentedJun 7, 2022•
edited
Loading

@mtarld I made changes and add more flexibility

@christian-kolb
Copy link

@alamirault That's an awesome addition I would love to have as part of the property normalizer.
I found a typo in your changes, but unfortunately hit the wrong button, my bad.
Is there anything I could do to help this PR getting done? 🙂

@alamiraultalamiraultforce-pushed theproperty-normalizer-visibility-options branch froma236feb tod21315eCompareJune 28, 2022 17:26
@alamirault
Copy link
ContributorAuthor

We need core member review. Maybe@dunglas ?

(Failed tests are not related)

christian-kolb reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@alamirault.

@fabpotfabpotforce-pushed theproperty-normalizer-visibility-options branch fromd21315e to8997aeeCompareJuly 22, 2022 08:32
@fabpotfabpot merged commitac87122 intosymfony:6.2Jul 22, 2022
@alamiraultalamirault deleted the property-normalizer-visibility-options branchAugust 7, 2022 17:21
@fabpotfabpot mentioned this pull requestOct 24, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mtarldmtarldmtarld requested changes

@fabpotfabpotfabpot approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@christian-kolbchristian-kolbchristian-kolb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.2

Development

Successfully merging this pull request may close these issues.

[Serializer] Configuration to ignore getters in ObjectNormalizer

5 participants

@alamirault@carsonbot@christian-kolb@fabpot@mtarld
[8]ページ先頭
©2009-2025 Movatter.jp