Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Added 46elks notifier bridge#44874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.1fromjongotlin:46elks-notifier
Jan 18, 2022

Conversation

@jongotlin
Copy link
Contributor

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#16350

46elks is a Swedish sms provider.

@jongotlin
Copy link
ContributorAuthor

Test is failing due to the transport is named46elks but classes are namedFortysixElks.... Shall I rename the transport tofortysix-elks or alterFrameworkExtensionTest somehow?

@OskarStark
Copy link
Contributor

@symfony/mergers how do we proceed with the class naming? Thanks

@Nyholm
Copy link
Member

Awesome. Thank you.

Could you add this package to the root composer.json'sreplace section? I would also like to see fabbot.io happy (just some CS)

About the naming... Hm.. Im not sure. If you dont mind, I suggest to rename the transport tofortysix-elks or similar so the test passes.

@jongotlin
Copy link
ContributorAuthor

Did I understand you correctly about replace@Nyholm?

I made the test pass by ignoring this transport. I think it's a (slightly) better solution than renaming the transport to something that is not the service/company name.

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I could go either way.

I saw now that there already were some exceptions in that test.

I’m happy with this pr

@OskarStark
Copy link
Contributor

@Nyholm I am not sure about the replace section 🧐

@Nyholm
Copy link
Member

@Nyholm I am not sure about the replace section 🧐

Oh. I was just reading the CI output. I thought we did that for all bridges. See thejob

@fancyweb Maybe we did a misstakehere?

@Nyholm
Copy link
Member

@OskarStark you are correct. It should not be in the composer's replace section. The CI job was wrong. I've updated the CI job in#44894

@OskarStark
Copy link
Contributor

Thanks Tobias!

@jongotlin
Copy link
ContributorAuthor

Squashed and rebased.@Nyholm@OskarStark

OskarStark reacted with heart emoji

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

random comment :)

@carsonbotcarsonbot changed the titleAdded 46elks notifier bridge[Notifier] Added 46elks notifier bridgeJan 4, 2022
@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJan 4, 2022
edited
Loading

FortySix or Fortysix
But also 46 or fortysix or forty-six in the package name (and maybe in the service name of course)

@fabpot
Copy link
Member

If we use letters instead of numbers, that would beFortySix (F and S uppercased), and soforty-six for the package name and where we need underscore names.

In any case, we need to be consistent and only use one or the other, not both.

OskarStark and jongotlin reacted with thumbs up emoji

@jongotlin
Copy link
ContributorAuthor

Renamed classes and transport. Some places still refers to 46elks but that's more about the company rather than the implementation. But some are in between and I'm not sure what to use 🤷

@jongotlin
Copy link
ContributorAuthor

Regarding naming, isn'tfortysix-elks more correct thanforty-six-elks? It is referring to46 and not40 6.

@stof
Copy link
Member

@jongotlin the textual version of 46 isforty-six, notfortysix

@jongotlin
Copy link
ContributorAuthor

@stof, ok thanks. Didn't know.

@fabpot
Copy link
Member

Thank you@jongotlin.

@fabpotfabpot merged commit6153815 intosymfony:6.1Jan 18, 2022
@jongotlinjongotlin deleted the 46elks-notifier branchJanuary 18, 2022 07:16
@fabpotfabpot mentioned this pull requestApr 15, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@NyholmNyholmAwaiting requested review from Nyholm

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

7 participants

@jongotlin@OskarStark@Nyholm@nicolas-grekas@fabpot@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp