Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Notifier] Added 46elks notifier bridge#44874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jongotlin commentedDec 31, 2021
Test is failing due to the transport is named |
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransport.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransport.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransport.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortysixElks/FortysixElksTransportFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortysixElks/Tests/success-response.jsonShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedJan 2, 2022
@symfony/mergers how do we proceed with the class naming? Thanks |
Nyholm commentedJan 2, 2022
Awesome. Thank you. Could you add this package to the root composer.json's About the naming... Hm.. Im not sure. If you dont mind, I suggest to rename the transport to |
jongotlin commentedJan 2, 2022
Did I understand you correctly about replace@Nyholm? I made the test pass by ignoring this transport. I think it's a (slightly) better solution than renaming the transport to something that is not the service/company name. |
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I could go either way.
I saw now that there already were some exceptions in that test.
I’m happy with this pr
OskarStark commentedJan 3, 2022
@Nyholm I am not sure about the replace section 🧐 |
Nyholm commentedJan 3, 2022
@OskarStark you are correct. It should not be in the composer's replace section. The CI job was wrong. I've updated the CI job in#44894 |
OskarStark commentedJan 3, 2022
Thanks Tobias! |
Uh oh!
There was an error while loading.Please reload this page.
jongotlin commentedJan 3, 2022
Squashed and rebased.@Nyholm@OskarStark |
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
random comment :)
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortysixElks/Tests/FortysixElksTransportTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedJan 4, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
FortySix or Fortysix |
fabpot commentedJan 5, 2022
If we use letters instead of numbers, that would be In any case, we need to be consistent and only use one or the other, not both. |
jongotlin commentedJan 5, 2022
Renamed classes and transport. Some places still refers to 46elks but that's more about the company rather than the implementation. But some are in between and I'm not sure what to use 🤷 |
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortySixElks/Tests/FortySixElksTransportFactoryTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Notifier/Bridge/FortySixElks/FortySixElksTransportFactory.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
jongotlin commentedJan 13, 2022
Regarding naming, isn't |
stof commentedJan 13, 2022
@jongotlin the textual version of 46 is |
jongotlin commentedJan 13, 2022
@stof, ok thanks. Didn't know. |
fabpot commentedJan 18, 2022
Thank you@jongotlin. |
46elks is a Swedish sms provider.