Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mime][Security] Fix missing sprintf and add tests#44822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4632643 to0c66f91Compare
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(for 5.3)
fabpot commentedDec 28, 2021
Can you rebase on 5.3 an create another PR for the exception that did not exist back then? |
alamirault commentedDec 28, 2021
This PR is now only for AccessListener (6.0). #44824 for DkimSigner (5.3) Is it ok ? did I misunderstand ? |
This PR was squashed before being merged into the 5.3 branch.Discussion----------[Mime] Fix missing sprintf in DkimSigner| Q | A| ------------- | ---| Branch? | 5.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |#44822 has 2 targets (5.3 for DkimSigner, 6.0 for AccessListener)Commits-------52ceda7 [Mime] Fix missing sprintf in DkimSigner
ea4e72f toc1954f8Comparefabpot commentedDec 28, 2021
Thank you@alamirault. |
#44808 fix one missing sprintf. This PR fix other cases and add tests.