Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] [LocoProvider] Use rawurlencode and separate tag setting#44816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.3fromdanut007ro:loco_provider_comma
Dec 28, 2021

Conversation

@danut007ro
Copy link
Contributor

@danut007rodanut007ro commentedDec 28, 2021•
edited by nicolas-grekas
Loading

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

According toLoco documentation when setting tag to multiple assets, the ids must be comma separated. Because local translation ids can contain comma, I handle separately those ids and add tag one by one.

I also addedrawurlencode for every request made to Loco. It was already used once inside theread method, but I added it everywhere.

@carsonbotcarsonbot added this to the5.4 milestoneDec 28, 2021
@carsonbotcarsonbot changed the title[Translator] [LocoProvider] Use rawurlencode and separate tag setting[Translation] [LocoProvider] Use rawurlencode and separate tag settingDec 28, 2021
@nicolas-grekas
Copy link
Member

Thank you@danut007ro.

@nicolas-grekasnicolas-grekas merged commita11f8b0 intosymfony:5.3Dec 28, 2021
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@jderussejderusseAwaiting requested review from jderusse

@lyrixxlyrixxAwaiting requested review from lyrixx

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@wouterjwouterjAwaiting requested review from wouterj

@xabbuhxabbuhAwaiting requested review from xabbuh

@ycerutoycerutoAwaiting requested review from yceruto

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@danut007ro@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp