Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] fix compat with apcu < 5.1.10#44799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
StaffNowa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good job. Only I have one question about comments inside code :)
| $ids =array_flip($ids); | ||
| foreach (apcu_fetch(array_keys($ids)) ?: []as$k =>$v) { | ||
| if (!isset($ids[$k])) { | ||
| // work around https://github.com/krakjoe/apcu/issues/247 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
SymfonyInsight. Do we need to have here comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think so yes, I don't want to remove that line again by mistake
Uh oh!
There was an error while loading.Please reload this page.
(Not needed on 6.0)