NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Notifier] Use correct factory for the msteams transport#44771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.3fromveewee:5.3-teams-notifier

Dec 23, 2021

Merged

[Notifier] Use correct factory for the msteams transport#44771

fabpot merged 1 commit intosymfony:5.3fromveewee:5.3-teams-notifier

Dec 23, 2021

Conversation

Copy link

Contributor

veewee commentedDec 23, 2021

Q	A
Branch?	5.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR

Creating a microsoft teams transport through theNotifierTransport::fromDsn() class results in an exception:

PHP Fatal error:  Uncaught TypeError: Symfony\Component\Notifier\Bridge\MicrosoftTeams\MicrosoftTeamsTransport::__construct(): Argument #1 ($path) must be of type string, null given, called in /vendor/symfony/notifier/Transport.php on line 186 and defined in /vendor/symfony/microsoft-teams-notifier/MicrosoftTeamsTransport.php:35Stack trace:* snap *

This PR uses the correct ms teams transport factory instead.
It is pointed at the5.3 branch, in which this specific transport was introduced.
The error is also there in all versions upwards. Seehttps://github.com/symfony/symfony/blob/6.1/src/Symfony/Component/Notifier/Transport.php#L84