Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Finder] Restore Finder:getIterator return type PHPDoc#44731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:6.0fromwerlos:restore_finder_get_iterator_return_type_phpdoc
Dec 21, 2021
Merged

[Finder] Restore Finder:getIterator return type PHPDoc#44731

derrabus merged 1 commit intosymfony:6.0fromwerlos:restore_finder_get_iterator_return_type_phpdoc
Dec 21, 2021

Conversation

@kubawerlos
Copy link
Contributor

QA
Branch?6.0
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44697
LicenseMIT

As discussed in the related ticket we want this annotation back. Targeting6.0 as it is present in5.4, was remove during merging5.4 up to6.0.

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@kubawerlos
Copy link
ContributorAuthor

No dear bot@carsonbot, this one is a GitHub issue:community/community#5634

@stof
Copy link
Member

oh, I was not aware of the fact that this feature was not available for forks belonging to an organization. Maybe carsonbot could detect that case.

kubawerlos reacted with thumbs up emoji

@fancywebfancyweb changed the base branch from6.1 to6.0December 20, 2021 17:48
@fancywebfancyweb modified the milestones:6.1,6.0Dec 20, 2021
@carsonbotcarsonbot changed the titleRestore Finder:getIterator return type PHPDoc[Finder] Restore Finder:getIterator return type PHPDocDec 20, 2021
@kubawerlos
Copy link
ContributorAuthor

@stof or GitHub will fix this, I didn't know about this as well, until carsonbot's message, doesn't look like a feature.

@derrabus
Copy link
Member

Good catch, thanks@kubawerlos.

@derrabusderrabus merged commit4d164da intosymfony:6.0Dec 21, 2021
fabpot added a commit that referenced this pull requestDec 21, 2021
…ovariant IteratorAggregate implementations (derrabus)This PR was merged into the 6.0 branch.Discussion----------[EventDispatcher][HttpFoundation] Restore return type to covariant IteratorAggregate implementations| Q             | A| ------------- | ---| Branch?       | 6.0| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | Follows#44731| License       | MIT| Doc PR        | N/ACommits-------0f2b5bb Restore return type to covariant IteratorAggregate implementations
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus approved these changes

+1 more reviewer

@fancywebfancywebfancyweb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

Symfony\Component\Finder\Finder::getIterator return type annotation removed

5 participants

@kubawerlos@carsonbot@stof@derrabus@fancyweb
[8]ページ先頭
©2009-2025 Movatter.jp