Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] fix Email HTML preview#44714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4from94noni:fx-profiler-mail
Dec 21, 2021

Conversation

@94noni
Copy link
Contributor

@94noni94noni commentedDec 19, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44696Fix#44703
LicenseMIT

First issue:

When swapping the order ofbase64 &charset=utf-8 it works well
Friendly ping@lyrixx as PR author

Second issue:

Friendly ping@Art4 as issue author

As theMime\Email is:

/**     * @return resource|string|null     */publicfunctiongetHtmlBody()    {return$this->html;    }

@carsonbotcarsonbot added this to the6.1 milestoneDec 19, 2021
@carsonbotcarsonbot changed the title[Profiler] fix HTML preview for null html body[WebProfilerBundle] fix HTML preview for null html bodyDec 19, 2021
@94noni94noni changed the base branch from6.1 to5.4December 19, 2021 17:53
@94noni94noni changed the title[WebProfilerBundle] fix HTML preview for null html body[WebProfilerBundle] fix HTML previewDec 19, 2021
@94noni94noni changed the title[WebProfilerBundle] fix HTML preview[WebProfilerBundle] fix Email HTML previewDec 19, 2021
@94noni94noniforce-pushed thefx-profiler-mail branch 2 times, most recently fromc7773cf to1116948CompareDecember 19, 2021 20:00
@fabpotfabpot modified the milestones:6.1,5.4Dec 21, 2021
@fabpot
Copy link
Member

Thank you@94noni.

94noni reacted with thumbs up emoji

@fabpotfabpot merged commita42dbe3 intosymfony:5.4Dec 21, 2021
@94noni94noni deleted the fx-profiler-mail branchDecember 22, 2021 05:26
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@lyrixxlyrixxlyrixx approved these changes

@stofstofstof approved these changes

+1 more reviewer

@Art4Art4Art4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@94noni@fabpot@lyrixx@stof@Art4@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp