Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Skip auto-validation for empty auto_mapping#44698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedDec 19, 2021
Hey! I think@jschaedl has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
ogizanagi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, can't dig much right now, but, with this patch, would:
framework:validation:auto_mapping:[]
still allow enabling auto mapping per-case by adding the@Assert\EnableAutoMapping annotation/attribute ?
And would
framework:validation:auto_mapping:App\Entity\:[]
still auto validateApp\Entity\ ns while requiring to add@Assert\EnableAutoMapping for the other ns?
IIRC, this would be the expected behavior.
src/Symfony/Component/Validator/DependencyInjection/AddAutoMappingConfigurationPass.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…pingConfigurationPass.phpCo-authored-by: Maxime Steinhausser <ogizanagi@users.noreply.github.com>
ro0NL commentedDec 21, 2021
yeah, no 😭 What bugs me more at this point is why nobody is noticing. That includes me now. |
alanpoulain commentedDec 21, 2021
Probably related? I had this kind of issue a long time ago... |
Uh oh!
There was an error while loading.Please reload this page.
I can confirm this fixes the issue on our side at 4.4.
I created this PR mostly to see what tests do on your side. 🤞 I'm not planning to digest this feature any further :)
I let you decide as of which branch to disable auto-validation ;)