Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition#44670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:6.1fromTristanPouliquen:allow_request_matcher_in_access_control
Jan 31, 2022
Merged

[SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definition#44670

derrabus merged 1 commit intosymfony:6.1fromTristanPouliquen:allow_request_matcher_in_access_control
Jan 31, 2022

Conversation

@TristanPouliquen
Copy link
Contributor

@TristanPouliquenTristanPouliquen commentedDec 16, 2021•
edited by derrabus
Loading

QA
Branch?6.1
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#44103
LicenseMIT
Doc PRsymfony/symfony-docs#16296

This PR allows users to directly specify a service reference in the definition of an access control rule. The given service MUST implement theRequestMatcherInterface.

The goal is to be able to pass custom request matchers, with more complex rules than the standard path, host, ips, ... options to have the same flexibility as the user has in defining his/her firewalls.

keichinger reacted with rocket emoji
@TristanPouliquen
Copy link
ContributorAuthor

I am going on holidays, as said in the Symfony Slack, I was unable to do acomposer update on the 5.4 branch so was unable to run tests locally.

If someone wants to finish the work, go for it, otherwise I'll finish in January :-)

@derrabus
Copy link
Member

I was unable to do acomposer update on the 5.4 branch

Note that 6.1 is our current feature branch. 5.4 is closed for features.

TristanPouliquen added a commit to TristanPouliquen/symfony-docs that referenced this pull requestDec 16, 2021
TristanPouliquen added a commit to TristanPouliquen/symfony-docs that referenced this pull requestDec 16, 2021
TristanPouliquen added a commit to TristanPouliquen/symfony-docs that referenced this pull requestDec 16, 2021
@TristanPouliquen
Copy link
ContributorAuthor

So no way of having this new small feature before SF6.1? That would be a shame imo

@wouterj
Copy link
Member

So no way of having this new small feature before SF6.1? That would be a shame imo

Yes. We only merge features in the unstable branch. For already released versions, stability is top priority so there should be as little changes in each patch release as possible (and definitely no new features).

derrabus reacted with thumbs up emoji

@derrabus
Copy link
Member

So no way of having this new small feature before SF6.1?

No way, sorry.

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for adding this feature! Adding support for a custom request matcher makes sense to me.

@carsonbotcarsonbot changed the titleAllow to specify a RequestMatcher directly in an ACL definition[SecurityBundle] Allow to specify a RequestMatcher directly in an ACL definitionJan 3, 2022
@TristanPouliquen
Copy link
ContributorAuthor

The final failing checks fail on issues that I don't think are related to my code. What can I do about it?

@TristanPouliquen
Copy link
ContributorAuthor

@derrabus Do you have time to review the final changes? Should I implement the configuration exception you were talking about?

@TristanPouliquen
Copy link
ContributorAuthor

@chalasr I see that your review is required too here :-)

@chalasr
Copy link
Member

Looks good to me once Alexander's comment is addressed (please ping if the given material is not enough)

@TristanPouliquen
Copy link
ContributorAuthor

I still have a failing check with Psalm, but the error seems to be on loading Psalm, so I don't know what I can do about it!

@chalasr
Copy link
Member

Can you update the SecurityBundle's changelog? The psalm issue is unrelated.

TristanPouliquen reacted with thumbs up emoji

@derrabus
Copy link
Member

Thank you@TristanPouliquen.

@derrabusderrabus merged commit96e7830 intosymfony:6.1Jan 31, 2022
@TristanPouliquenTristanPouliquen deleted the allow_request_matcher_in_access_control branchJanuary 31, 2022 16:19
TristanPouliquen added a commit to TristanPouliquen/symfony-docs that referenced this pull requestFeb 1, 2022
TristanPouliquen added a commit to TristanPouliquen/symfony-docs that referenced this pull requestFeb 3, 2022
@fabpotfabpot mentioned this pull requestApr 15, 2022
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestJun 28, 2022
…stanPouliquen)This PR was squashed before being merged into the 6.1 branch.Discussion----------[Security] Reference the new request_matcher optionLinked tosymfony/symfony#44670<!--If your pull request fixes a BUG, use the oldest maintained branch that containsthe bug (seehttps://symfony.com/releases for the list of maintained branches).If your pull request documents a NEW FEATURE, use the same Symfony branch wherethe feature was introduced (and `5.x` for features of unreleased versions).-->Commits-------f0432c4 [Security] Reference the new request_matcher option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@derrabusderrabusderrabus approved these changes

@chalasrchalasrchalasr approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

[Security][Access Control] Allow definition of a custom RequestMatcher in access control rules like in firewalls

5 participants

@TristanPouliquen@derrabus@wouterj@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp