Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] disable lock on CLI#44669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?
TicketsFix#41130
LicenseMIT
Doc PR-

I thought using semaphores would fix the linked issue but I'm proposing to revert them in#44667

Instead, I think we should disable the lock on CLI processes.

The purpose of having locks enabled by default is to prevent cache stamped at deploy time. Disabling the lock on CLI still provides this protection on eg FPM.

For ppl that really want a lock between eg crons and FPM, the lock component should be used instead.

@stof
Copy link
Member

The issue was talking about problems happening in Apache, so I doubt that disabling it only on CLI will fix it.

@nicolas-grekas
Copy link
MemberAuthor

It was about apache calling commands in a subprocess, isn't it?

@stof
Copy link
Member

#41130 (comment) should be checked, as it talks about nested caching in parallell requests

@nicolas-grekas
Copy link
MemberAuthor

CallingLockRegistry::setFiles([]) will work for these cases.

@nicolas-grekasnicolas-grekas merged commit311dc83 intosymfony:4.4Dec 16, 2021
@nicolas-grekasnicolas-grekas deleted the cache-no-lock-on-cli branchDecember 16, 2021 22:25
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolas-grekas@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp