Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache] Revert "feature #41989 makeLockRegistry use semaphores when possible"#44667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
LockRegistry use semaphores when possible"LockRegistry use semaphores when possible"stof approved these changesDec 16, 2021
chalasr approved these changesDec 16, 2021
nicolas-grekas added a commit that referenced this pull requestDec 16, 2021
This PR was merged into the 4.4 branch.Discussion----------[Cache] disable lock on CLI| Q | A| ------------- | ---| Branch? | 5.4| Bug fix? | yes| New feature? | no| Deprecations? || Tickets |Fix#41130| License | MIT| Doc PR | -I thought using semaphores would fix the linked issue but I'm proposing to revert them in#44667Instead, I think we should disable the lock on CLI processes.The purpose of having locks enabled by default is to prevent cache stamped at deploy time. Disabling the lock on CLI still provides this protection on eg FPM.For ppl that really want a lock between eg crons and FPM, the lock component should be used instead.Commits-------b968514 [Cache] disable lock on CLI
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit479919d, reversing
changes made to356c953.
I'd like to revert this PR because using semaphores is creating problems that don't have any easy solution.