Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PropertyInfo] PhpStan extractor nested object fix#44637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@rmikalkenas
Copy link
Contributor

@rmikalkenasrmikalkenas commentedDec 15, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

PhpStanExtractor wrongly extracts object type when it is in a different namespace

@carsonbot
Copy link

Hey!

I think@Korbeil has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some cs issues and GTM

}

privatefunctionextractFromFullClassName(string$fullClassName):array
privatefunctioncollectUses(\ReflectionClass$reflection):array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

collectTraits would be a better name IMHO

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinkcollectUses sounds more logic in this context, because method collects not only traits, but class uses as well

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@nicolas-grekas rebased the branch, waiting for yours input on remaining issue

Copy link
Contributor

@KorbeilKorbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Apart from Nicolas CS fixes it looks good to me too 👍

@nicolas-grekas
Copy link
Member

Thank you@rmikalkenas.

rmikalkenas reacted with hooray emoji

@nicolas-grekasnicolas-grekas merged commitfa99027 intosymfony:5.4Dec 26, 2021
This was referencedDec 29, 2021
@rmikalkenasrmikalkenas deleted the phpstan-extractor-fix branchJuly 19, 2022 13:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@KorbeilKorbeilKorbeil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@rmikalkenas@carsonbot@nicolas-grekas@Korbeil
[8]ページ先頭
©2009-2025 Movatter.jp