Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Inflector] Correct the spelling of matracies to matraces#44632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gnito-org wants to merge2 commits intosymfony:4.4fromgnito-org:spelling-inflectortest-4-4
Closed

[Inflector] Correct the spelling of matracies to matraces#44632

gnito-org wants to merge2 commits intosymfony:4.4fromgnito-org:spelling-inflectortest-4-4

Conversation

@gnito-org
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix #...
LicenseMIT
Doc PRsymfony/symfony-docs#...

@carsonbotcarsonbot added this to the4.4 milestoneDec 14, 2021
@carsonbotcarsonbot changed the titleCorrect the spelling of matracies to matraces[Inflector] Correct the spelling of matracies to matracesDec 14, 2021
@nicolas-grekas
Copy link
Member

This breaks tests. More lines need to be changed apparently.

@gnito-org
Copy link
ContributorAuthor

The errors all conform to the following pattern:

3) Symfony\Component\Inflector\Tests\InflectorTest::testPluralize with data set #73 ('matrix', array('matrices', 'matrixes'))Failed asserting that two arrays are equal.--- Expected+++ Actual@@ @@ Array (-    0 => 'matrices'+    0 => 'matricies'     1 => 'matrixes' )

However, the wordmatricies does not occur anywhere in the branch where I corrected the spelling. So, from where is the test getting it?

@nicolas-grekas
Copy link
Member

You might want to take inspiration from eg#43790 which fixes something similar for another word.

@gnito-org
Copy link
ContributorAuthor

Unfortunately that does not help. I still do not see from where the test is getting the "matricies" that it's listing in the "Actual" line.

@gnito-org
Copy link
ContributorAuthor

The more overarching question is, why are the tests also failing on other words (fungus, hero) that have nothing to do with the one word I changed insrc/Symfony/Component/Inflector/Tests/InflectorTest.php.

Shouldn't those other words cause failures in all CI tests that do not include my word change?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

4 participants

@gnito-org@nicolas-grekas@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp