Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Inflector] Correct the spelling of matracies to matraces#44632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
gnito-org commentedDec 14, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #... |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
nicolas-grekas commentedDec 15, 2021
This breaks tests. More lines need to be changed apparently. |
gnito-org commentedDec 15, 2021
The errors all conform to the following pattern: However, the word |
nicolas-grekas commentedDec 15, 2021
You might want to take inspiration from eg#43790 which fixes something similar for another word. |
gnito-org commentedDec 15, 2021
Unfortunately that does not help. I still do not see from where the test is getting the "matricies" that it's listing in the "Actual" line. |
gnito-org commentedDec 15, 2021
The more overarching question is, why are the tests also failing on other words (fungus, hero) that have nothing to do with the one word I changed insrc/Symfony/Component/Inflector/Tests/InflectorTest.php. Shouldn't those other words cause failures in all CI tests that do not include my word change? |