Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Handle the blank-translation in Loco Adapter#44598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kgonella
Copy link
Contributor

QA
Branch?5.3, 5.4, 6.0
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44595
LicenseMIT

This PR aim to be able to pull the "blank-translation" in addition to "translated" status translations. See the ticket to know more about. I don't think we can add a unit test here as the calls to loco are fully mocked.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think@rvanlaak has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@kgonellakgonellaforce-pushed thefeature/handle-blank-translation-in-loco-adapter branch from7e44cff to629804eCompareDecember 15, 2021 13:05
@kgonellakgonellaforce-pushed thefeature/handle-blank-translation-in-loco-adapter branch from629804e to8b18a27CompareDecember 15, 2021 13:11
@nicolas-grekas
Copy link
Member

Thank you@kgonella.

@nicolas-grekasnicolas-grekas merged commite5d3dea intosymfony:5.3Dec 15, 2021
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

4 participants

@kgonella@carsonbot@nicolas-grekas@welcoMattic
[8]ページ先頭
©2009-2025 Movatter.jp