Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

JS: use startsWith()#44593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@alexislefebvre
Copy link
Contributor

QA
Branch?6.1
Bug fix?no
New feature?no
Deprecations?no
TicketsSimilar to#44499, but with JSFix
LicenseMIT
Doc PR-

It's standart:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith

@carsonbotcarsonbot added this to the6.1 milestoneDec 13, 2021
@stof
Copy link
Member

The JS code running for the toolbar is expected to have the widest browser support possible, because this runs in the app page directly, and we don't want those pages to be restricted in their browser support just because the Symfony debug toolbar breaks the JS.
Our toolbar code is currently still compatible with IE, and this PR would break it (note that I'm specifically talking about the toolbar, not about the web profiler UI which renders its own pages)

alexislefebvre reacted with thumbs up emoji

@alexislefebvre
Copy link
ContributorAuthor

Thanks for the information.

My bad, I thought that IE was unsupported for 5+ years, since Edge was released.

@alexislefebvrealexislefebvre deleted the js-use-startsWith branchDecember 13, 2021 13:48
@stof
Copy link
Member

@alexislefebvre lots of enterprise tools still need to support IE due to their user base (though this is gradually going down, thanks to Microsoft pushing for the end of support of IE11).
And as Symfony has no knowledge about the intended browser support of projects, the web debug toolbar should avoid forcing to reduce that range by causing errors. for the web profiler UI, we already dropped support for IE 11 a while ago.

My bad, I thought that IE was unsupported for 5+ years, since Edge was released.

IE 11 is still supported until June 2022 on Windows 10 (after which the IE mode of the new Edge will be the only supported way to run a page needing IE on Windows 10) and until the EOL of Windows 8 (which is in 2023) on Windows 8.

alexislefebvre reacted with thumbs up emoji

@alexislefebvre
Copy link
ContributorAuthor

Thanks for the detailed report.

@alexislefebvre
Copy link
ContributorAuthor

alexislefebvre commentedJun 16, 2022
edited
Loading

@stof can we reopen this PR now that IE is unsupported? 🙂https://docs.microsoft.com/en-us/lifecycle/announcements/internet-explorer-11-end-of-support


Update: my bad, you already answered:

and until the EOL of Windows 8 (which is in 2023) on Windows 8

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.1

Development

Successfully merging this pull request may close these issues.

4 participants

@alexislefebvre@stof@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp