Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] add SerializedMessageStamp#44589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedDec 14, 2021
Hey! I think@monteiro has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
ogizanagi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks sensible to me 👍🏻
Uh oh!
There was an error while loading.Please reload this page.
nikophil commentedDec 31, 2021
hi@ogizanagi I also rebased on 6.1 |
chalasr commentedDec 31, 2021
Thank you@nikophil. |
This PRfixes#43496
When a message is sent for retry, we currently serialize it from the message POPO object whereas we already had the serialized representation of the message before deserializing it.
This solution proposes to store the serialized message in a "not serializable" stamp when we receive the message. Then the serialized message will be used in
\Symfony\Component\Messenger\Transport\Serialization\Serializer::encode(), if the message is retried, which prevents to serialize the message again.This has several advantages, mainly when we're dealing with big payloads: