Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Cache] Fix proxy no expiration to the Redis#44577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sbelyshkin
Copy link
Contributor

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR

After#38156 RedisAdapter is not able to persist items with no expiration which come through ProxyAdapter because Redis does not persist keys with very large TTL such as \PHP_INT_MAX (64 bits).

@carsonbotcarsonbot added this to the4.4 milestoneDec 12, 2021
@sbelyshkinsbelyshkinforce-pushed thefix-proxy-no-expiration branch 3 times, most recently fromcd6cb2b to65bf172CompareDecember 12, 2021 13:58
@sbelyshkin
Copy link
ContributorAuthor

Looks like UnitTest fails because Redis cannot connect togetenv('REDIS_HOST') while other tests work well with this variable. How can I rewrite the test?

@carsonbot
Copy link

Hey!

I think@ajcerezo has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, here are some comments before accepting the change.

@sbelyshkinsbelyshkinforce-pushed thefix-proxy-no-expiration branch 2 times, most recently from484407c to8f8af9cCompareDecember 15, 2021 16:33
@nicolas-grekas
Copy link
Member

Thank you@sbelyshkin.

@nicolas-grekasnicolas-grekas merged commitaaa18df intosymfony:4.4Dec 16, 2021
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@sbelyshkin@carsonbot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp