Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[CI] Fix package-tests workflow checks for contracts#44511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Nyholm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you.
Awesome.
fabpot commentedDec 9, 2021
Thank you@fancyweb. |
| if [ $(_jq '.component_bridge')==false ]; then | ||
| if [ $TYPE=='component_bridge' ]; then | ||
| if [ ! $(cat composer.json | jq -e ".replace.\"$NAME\"|test(\"self.version\")") ]; then | ||
| echo "Composer.json's replace section needs to contain $NAME" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
why is this done only for component bridges ? bundles, normal bridges (other than the phpunit one which is special) and components (other than runtime which is a composer plugin) should also be replaced.
Andcontract type should be replaced insrc/Symfony/Contracts/composer.json file
…ection (Nyholm)This PR was merged into the 5.3 branch.Discussion----------[CI] If package is not bridge, it should be in replace section| Q | A| ------------- | ---| Branch? | 6.1| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR |Related to#44511. Ping `@fancyweb`We should only add packages in the root composer's replace section for bundles, packages and contracts. Ie everything but bridges.Commits-------d9f0d8e [CI] If package is not bridge, it should be in replace section
Our expectations are different for contracts.