Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove FQCN type hints on properties#44494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.0fromfabpot:preloading-fixes
Dec 9, 2021

Conversation

@fabpot
Copy link
Member

@fabpotfabpot commentedDec 7, 2021•
edited
Loading

QA
Branch?6.0
Bug fix?yes
New feature?no
Deprecations?no
Tickets#44364
LicenseMIT
Doc PRn/a

This is an alternative for#44380.
Basically, we are removing all property type hints on 6.0 and reverts that for 6.1.

Wirone, Hanmac, ging-dev, DavidBadura, rvanlaak, xorik, ste93cry, and BafS reacted with confused emoji
@fabpotfabpotforce-pushed thepreloading-fixes branch 2 times, most recently from82499e0 to80ea634CompareDecember 8, 2021 08:40
@fabpot
Copy link
MemberAuthor

This one is ready

@fabpotfabpot merged commit0a13eba intosymfony:6.0Dec 9, 2021
@fabpotfabpot deleted the preloading-fixes branchDecember 9, 2021 12:42
fabpot added a commit that referenced this pull requestDec 9, 2021
@fabpotfabpot mentioned this pull requestDec 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@wouterjwouterjAwaiting requested review from wouterjwouterj is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

+1 more reviewer

@fancywebfancywebfancyweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@fabpot@nicolas-grekas@stof@fancyweb@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp