Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Fix compatibility with symfony/security-core 6.x (deps=high tests)#44427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| { | ||
| // @deprecated since Symfony 5.4 | ||
| if (!class_exists(AnonymousToken::class)) { | ||
| $this->markTestSkipped('This test requires "symfony/security-core" <6.0.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This test is irrelevant in 6.0, as anonymous tokens are removed and anonymous sessions are now null anyways (so no conversion is needed inAbstractController::getUser()).
| $token =newUsernamePasswordToken($user,'pass','default', ['ROLE_USER']); | ||
| }else { | ||
| $token =newUsernamePasswordToken($user,'default', ['ROLE_USER']); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Expected BC break, correct deprecations are triggered on 5.4.
| // @deprecated since Symfony 5.4 | ||
| if (method_exists($token,'setAuthenticated')) { | ||
| $token->setAuthenticated(true); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The real bugfix of this PR, this adds support for security-core 6.0 in FrameworkBundle.
fabpot commentedDec 3, 2021
Thank you@wouterj. |
Uh oh!
There was an error while loading.Please reload this page.
Complete diff of this PR must be removed when upmerging to 6.0.