Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Lock] Create tables in transaction only if supported by driver#44383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4frommartinssipenko:lock-table-creation
Dec 20, 2021

Conversation

@martinssipenko
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

FixedDoctrineDbalStore to allow the creation of a lock table within a transaction only if it is supported by the driver.

@martinssipenko
Copy link
ContributorAuthor

@jderusse I've updated code to use Platform now, but I don't quite understand why tests on 7.2 are failing.

@jderusse
Copy link
Member

I don't quite understand why tests on 7.2 are failing.

Tests are falling because the classPostgreSQLPlatform, does not exist in a version compatible with PHP 7.2. That's whygetCurrentTimestampStatement used platform instead of driver.

@derrabus
Copy link
Member

derrabus commentedDec 2, 2021
edited
Loading

Tests are falling because the classPostgreSQLPlatform, does not exist in a version compatible with PHP 7.2.

It does, but with different casing. Add this to the top of the test file, to trigger the autoloader with the old class name as well:

class_exists('Doctrine\DBAL\Platforms\PostgreSqlPlatform');

@martinssipenko
Copy link
ContributorAuthor

Alright, CI is finally green.@jderusse@derrabus could you take a look at it?

@martinssipenko
Copy link
ContributorAuthor

@jderusse@derrabus any updates on this?

@martinssipenko
Copy link
ContributorAuthor

@jderusse Any updates here? CI just keeps failing randomly, not sure what can/should I do about it.

@fabpot
Copy link
Member

Thank you@martinssipenko.

@fabpotfabpot merged commit83dbb47 intosymfony:5.4Dec 20, 2021
@martinssipenkomartinssipenko deleted the lock-table-creation branchDecember 20, 2021 10:19
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@GromNaNGromNaNGromNaN approved these changes

@derrabusderrabusAwaiting requested review from derrabus

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

@stofstofAwaiting requested review from stof

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@martinssipenko@jderusse@derrabus@fabpot@nicolas-grekas@GromNaN@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp