Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Lock] create lock table if it does not exist#44370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:5.4frommartinssipenko:gh-44369
Nov 30, 2021

Conversation

@martinssipenko
Copy link
Contributor

@martinssipenkomartinssipenko commentedNov 30, 2021•
edited by derrabus
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44369
LicenseMIT
Doc PRN/A

Fix bug where tables are not automatically created when usingSymfony\Component\Lock\Store\DoctrineDbalStore.

andrewmy reacted with rocket emoji
@derrabus
Copy link
Member

Can you please add a test?

@martinssipenko
Copy link
ContributorAuthor

@derrabus I'd be happy to, but given this is my first contribution to Symfony and none of the other sites have tests for this case I would need some guidance.

@martinssipenko
Copy link
ContributorAuthor

@derrabus check the last commit, perhaps that would work? If remove thecreateTable() invocation fromDoctrineDbalStore and/orPdoStore the tests will fail now.

@derrabus
Copy link
Member

Thank you@martinssipenko for taking care of this regression.

@derrabusderrabus merged commit4a07e06 intosymfony:5.4Nov 30, 2021
Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In PdoStore there is an extra check that assert there is no active transaction.
Shouldn't we do the same here ?

@GromNaN
Copy link
Member

Exact, there was the same check for DBAL in 5.3.https://github.com/symfony/symfony/blob/5.3/src/Symfony/Component/Lock/Store/PdoStore.php#L143

It is wise to add it back.

@jderusse
Copy link
Member

jderusse commentedNov 30, 2021•
edited
Loading

could you open a PR to handle it@martinssipenko?

@martinssipenkomartinssipenko deleted the gh-44369 branchDecember 1, 2021 05:27
@martinssipenko
Copy link
ContributorAuthor

@jderusse@GromNaN I've created a pull request to do this#44383

This was referencedDec 9, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderussejderusse left review comments

@GromNaNGromNaNGromNaN approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@martinssipenko@derrabus@GromNaN@jderusse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp