Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Fix redundant type casts#44330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix redundant type casts#44330
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| publicstaticfunctioncreateChoiceName(object$choice,$key,string$value):string | ||
| { | ||
| returnstr_replace('-','_',(string)$value); | ||
| returnstr_replace('-','_',$value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
string $value in args
| thrownew \InvalidArgumentException(sprintf('Unsupported verbosity group "%s", expected one of "%s".',$group,implode('", "',array_keys($this->verboseOutput)))); | ||
| } | ||
| $this->verboseOutput[$group] =(bool)$status; | ||
| $this->verboseOutput[$group] =$status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@param bool[] $verboseOutput in the doc + the constructor is private and only called with a$verboseOutput infromUrlEncodedString() andinWeakMode() and we always set valid booleans values.
| protectedfunctionrenderForm(FormView$view,array$vars = []):string | ||
| { | ||
| return(string)$this->renderer->renderBlock($view,'form',$vars); | ||
| return$this->renderer->renderBlock($view,'form',$vars); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
FormRendererInterface::renderBlock() returns a string
| } | ||
| $this->hidden =(bool)$hidden; | ||
| $this->hidden =$hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
bool $hidden in args
| publicfunctionsetHiddenFallback(bool$fallback) | ||
| { | ||
| $this->hiddenFallback =(bool)$fallback; | ||
| $this->hiddenFallback =$fallback; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
bool $fallback in args
| // Per RFC 4514, leading/trailing spaces should be encoded in DNs, as well as carriage returns. | ||
| if ((int)$flags & \LDAP_ESCAPE_DN) { | ||
| if ($flags & \LDAP_ESCAPE_DN) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
int $flags = 0 in args
| protectedfunctionassertValidLocale(string$locale) | ||
| { | ||
| if (!preg_match('/^[a-z0-9@_\\.\\-]*$/i',(string)$locale)) { | ||
| if (!preg_match('/^[a-z0-9@_\\.\\-]*$/i',$locale)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
string $locale in args
| { | ||
| if (str_contains($name,'\\') &&class_exists($name)) { | ||
| $className =(string)$name; | ||
| $className =$name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
string $name in args
| { | ||
| $data =clone$this; | ||
| $data->maxDepth =(int)$maxDepth; | ||
| $data->maxDepth =$maxDepth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
int $maxDepth in args
| { | ||
| $data =clone$this; | ||
| $data->maxItemsPerDepth =(int)$maxItemsPerDepth; | ||
| $data->maxItemsPerDepth =$maxItemsPerDepth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
int $maxItemsPerDepth in args
nicolas-grekas commentedNov 29, 2021
Thank you@fancyweb. |
Continuation of#44274 on 5.3