Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] #44254 Changing queue name precedence#44291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
aderiyenko wants to merge5 commits intosymfony:5.3
base:5.3
Choose a base branch
Loading
fromaderiyenko:changing_queue_name_precedence_44254

Conversation

aderiyenko
Copy link

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44254
LicenseMIT

Suggesting to change the precedence ofqueue_name option toconfig -> DSN -> default ("messages") instead of currentDSN -> config -> default ("messages")

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@aderiyenkoaderiyenko changed the base branch from5.4 to5.3November 26, 2021 16:28
Copy link
Member

@jderussejderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The DSN takes precedence over the options on purpose.

ie. PROD and PRE_PROD share the same configuration (and samequeue_name in the messenger.yaml) but they use 2 differents DSN to define the targeted queue.

If you want to share the same DSN across different configurations, you can either:

  • remove the queue name from the ENV variabnle, in that way, the connection will fallback to the option
  • make the queue name part the DSN. ie.dsn : "%env(MESSENGER_TRANSPORT_DSN)%/my_queue"

@aderiyenko
Copy link
Author

Thanks for your review@jderusse !

In this case I'll let the reporterhere know to just remove the queue name from the DSN and specify it explicitly in the options.

And then I just left a test for the default message name == 'messages' as I haven't found such a test in the suite.

LMK if it makes sense and thanks again!

@nicolas-grekasnicolas-grekas modified the milestones:7.1,6.4Nov 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@OskarStarkOskarStarkAwaiting requested review from OskarStark

@jderussejderusseAwaiting requested review from jderusse

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[AmazonSqsMessenger] DSN queue name overrides queue_name from options
5 participants
@aderiyenko@carsonbot@jderusse@fabpot@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp