Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Fix AllMySms bridge body content#44277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.3fromafiocre:fix/allmysms-1005-error-code
Nov 25, 2021

Conversation

@afiocre
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44276
LicenseMIT

Fix the 1005 error code from AllMySms bridge with Notifier component

qdequippe reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@afiocreafiocreforce-pushed thefix/allmysms-1005-error-code branch fromd1d7656 to376b3e5CompareNovember 25, 2021 16:05
Copy link
Contributor

@fancywebfancyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

https://doc.allmysms.com/api/en/#introduction

The body of the requests should be in JSON format

@fabpot
Copy link
Member

Thank you@afiocre.

@fabpotfabpot merged commitc236dfe intosymfony:5.3Nov 25, 2021
@afiocreafiocre deleted the fix/allmysms-1005-error-code branchNovember 26, 2021 07:59
This was referencedNov 29, 2021
@fabpotfabpot mentioned this pull requestDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

+2 more reviewers

@fancywebfancywebfancyweb approved these changes

@cbarrancolrqdocbarrancolrqdocbarrancolrqdo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

6 participants

@afiocre@carsonbot@fabpot@nicolas-grekas@fancyweb@cbarrancolrqdo
[8]ページ先頭
©2009-2025 Movatter.jp