Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Process] intersect with getenv() in case-insensitive manner to get default envs#44261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@stable-staple
Copy link
Contributor

@stable-staplestable-staple commentedNov 24, 2021•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#44260
LicenseMIT
Doc PR

Since environment variables are case-insensitive in Windows, all envs should be compared in case-insensitive manner.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@stable-staplestable-staple changed the base branch from5.4 to4.4November 24, 2021 22:39
@nicolas-grekasnicolas-grekas changed the title[Process] intersect with getenv() in case-insensitive manner to get d…[Process] intersect with getenv() in case-insensitive manner to get default envsNov 25, 2021
@nicolas-grekasnicolas-grekas modified the milestones:5.4,4.4Nov 25, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for spotting and submitting this!
I updated the patch a bit to make it Windows-specific and add similar logic in other places that needed it.

@stof
Copy link
Member

is it possible to add tests covering this to avoid regressions ?

…efault envs- since environment variables are case-insensitive in Windows,  all envs should be compared in case-insensitive manner
@nicolas-grekas
Copy link
Member

I added a test case.

@nicolas-grekas
Copy link
Member

Thank you@stable-staple.

@nicolas-grekasnicolas-grekas merged commitf86c557 intosymfony:4.4Nov 28, 2021
@stable-staplestable-staple deleted the proc-getenv-caseinsensitive branchNovember 28, 2021 21:08
This was referencedNov 29, 2021
This was referencedDec 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

[Process] Windows REG utility not recognized as an internal or external command

4 participants

@stable-staple@carsonbot@stof@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp