Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Processor] Fix environment string value problem#44257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Some libs send $env argument as string
carsonbot commentedNov 24, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
nicolas-grekas commentedNov 25, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm sorry but the patch doesn't make sense. |
| foreach ($envas$k =>$v) { | ||
| if (false !==$v &&'argc' !==$k &&'argv' !==$k) { | ||
| $envPairs[] =$k.'='.$v; | ||
| if(\is_array($env)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The code says everywhere thatenv should be an array, here most likely you need to think about theexplicit merging of two arrays, and not about checking for an array.
Some libs send $env argument as string
Sometimes environment come as string, generally from old libraries