Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Config] added EnumNode#4420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
travisbot commentedMay 26, 2012
Commits-------8308aea [Config] added EnumNodeDiscussion----------[Config] added EnumNodeThis adds an EnumNode which should be used instead of a Closure and manual validation.The benefit is that you can retrieve the allowed values. It is also a bit shorter, but that is not the main point here.---------------------------------------------------------------------------by travisbot at 2012-05-26T03:52:50ZThis pull request [passes](http://travis-ci.org/symfony/symfony/builds/1439264) (merged8308aea intoff4d446).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Missing: return $this;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I recommend, that you do a PR if this is till an issue. Also note, that you have to do a PR against the branch this feature was introduced in.
This adds an EnumNode which should be used instead of a Closure and manual validation.
The benefit is that you can retrieve the allowed values. It is also a bit shorter, but that is not the main point here.