Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient][Mime] Add correct IDN flags for IDNA2008 compliance#44119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromj-bernard:ticket_44091
Nov 19, 2021

Conversation

@j-bernard
Copy link
Contributor

@j-bernardj-bernard commentedNov 17, 2021•
edited by nicolas-grekas
Loading

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#44091#44092
LicenseMIT

Fix#44091
Fix#44092

@carsonbotcarsonbot added this to the4.4 milestoneNov 17, 2021
@carsonbotcarsonbot changed the titlebug #44091 [HttpClient] Add correct IDN flags for IDNA2008 compliance[HttpClient] bug #44091 Add correct IDN flags for IDNA2008 complianceNov 17, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Can you please fix#44092 in the same PR since that's the same topic?

j-bernard reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas changed the title[HttpClient] bug #44091 Add correct IDN flags for IDNA2008 compliance[HttpClient] Add correct IDN flags for IDNA2008 complianceNov 18, 2021
@j-bernard
Copy link
ContributorAuthor

I made the 2 updates. While making those, I noticed that in version 5.1 you allowed non-ASCII local-part without implementingRFC6531. See my bug report:#44136

@carsonbotcarsonbot changed the title[HttpClient] Add correct IDN flags for IDNA2008 compliance[HttpClient][Mime] Add correct IDN flags for IDNA2008 complianceNov 19, 2021
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(after@OskarStark's comment is fixed)

@fabpot
Copy link
Member

Thank you@j-bernard.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@j-bernard@carsonbot@nicolas-grekas@fabpot@OskarStark
[8]ページ先頭
©2009-2025 Movatter.jp