NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Make sure hostnames without a TLD can use hyphens and underscores#44087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Sacrome wants to merge1 commit intosymfony:5.3fromSacrome:5.3

Closed

Make sure hostnames without a TLD can use hyphens and underscores#44087

Sacrome wants to merge1 commit intosymfony:5.3fromSacrome:5.3

Conversation

Copy link

Sacrome commentedNov 16, 2021•
edited
Loading

Q	A
Branch?	5.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #...
License	MIT

This PR ensures hostnames without a TLD that contain hyphens and/or underscores are considered valid by the UrlValidator Constraint.

Make sure hostnames without a TLD can use hyphens and underscores

7e65c09

carsonbot added Status: Needs Review Bug labels

Nov 16, 2021

carsonbot added this to the5.3 milestone

Nov 16, 2021

Copy link

carsonbot commentedNov 16, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot