Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ErrorHandler] Fix FlattenException::setPrevious argument typing#44028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
326756e to21ec2b8Comparenicolas-grekas commentedNov 12, 2021
Can you please target 4.4? |
21ec2b8 to64143ddCompare
chalasr left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
be careful when merging up, signature is not the same on upper branches butnull should keep being supported
fabpot commentedNov 12, 2021
Thank you@welcoMattic. |
Uh oh!
There was an error while loading.Please reload this page.
The setter didn't accept
nullvalue, while the getter can returnnull. It can be a fix for the linked issue, but I'm not 100% sure about the cause of the issue (I'll try to make a reproducer soon).In the meantime, this typing bug seems to fix at least the case explained in the issue.