When a service is built by a factory, we don't always know if the resulting instance will implementResetInteface or not.
One such service ishttp_client:HttpClient::create() might return a curl-one or a native-one, and only the former is resettable.

This PR makes it possible to make a reset conditional, aka by ignoring when the reset method doesn't exist.
This is both a new feature for HttpKernel and a bugfix for thehttp_client service.
That's why I'm targeting 5.4.

[HttpKernel] allow ignoring kernel.reset methods that don't exist

47954bd

carsonbot added Status: Needs Review Bug Feature HttpKernel labels

Nov 9, 2021

carsonbot added this to the5.4 milestone

Nov 9, 2021

nicolas-grekas mentioned this pull request

Nov 9, 2021

[HttpKernel] Make sure that decorated service works with kernel.reset tag#43972

Closed

ogizanagi reviewed

Nov 9, 2021

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.phpShow resolvedHide resolved

src/Symfony/Component/HttpKernel/DependencyInjection/ResettableServicePass.phpShow resolvedHide resolved

nicolas-grekas changed the title~~[HttpKernel] allow ignoring kernel.reset methods that don't exist~~[HttpKernel] allow ignoring kernel.reset for methods that don't exist

Nov 9, 2021

nicolas-grekas changed the title~~[HttpKernel] allow ignoring kernel.reset for methods that don't exist~~[HttpKernel] allow ignoring kernel.reset methods that don't exist

Nov 9, 2021

ogizanagi approved these changes

Nov 9, 2021

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Nov 9, 2021