Thanks for the PR. I did think about that in the last days, and I'm not sure we should do it.

Decorators should be able to decorate the reset method as any other method. Forcing a direct call to the decorated service would be unexpected to me.

The issue that lead to this proposal has been closed and doesn't require this change, isn't it? It means there is already a working solution. Unless we have a real world use case that would allow us to reason about this topic, I think we should not do this.

Thanks for the PR. I did think about that in the last days, and I'm not sure we should do it.

Decorators should be able to decorate the reset method as any other method. Forcing a direct call to the decorated service would be unexpected to me.

The issue that lead to this proposal has been closed and doesn't require this change, isn't it? It means there is already a working solution. Unless we have a real world use case that would allow us to reason about this topic, I think we should not do this.

I see your point, but that would mean that every decorated service should also implement ResetInterface. Let's pick an example of HttpClientInterface: based on your suggestion, then client's interface should extend ResetInterface, because otherwise some other client's implementation (which is used as a decorator) might miss to implement ResetInterface leading to not resetting underlying decorated services (hopefully you get the idea I'm trying to explain)

@nicolas-grekas if the decorator needs to have its own resetting logic, the decorator itself should implement ResetInterface and so be tagged askernel.reset

client's interface should extend ResetInterface

That's correct (and that's also correct for any decorator, as@stof just wrote).

TraceableHttpClient already does so. Is this missing somewhere else where service decoration is used? A quick look makes me think we're OK.

Agree with both of you, but would also like to somehow enforce the developer who is implementing a custom HttpClientInterface to dont forget to add ResetInterface, because otherwise we will loose resetting functionality if that custom implementation is used as a decorator. WDYT@nicolas-grekas@stof

Meanwhile I see that quite some http clients are missing ResetInterface (exp.: RetryableHttpClient, CachingHttpClient and others), so probably will prepare a PR to add it

These decorators don't need to implement reset interface, unless they're used asservice decorators (they're not to my knownledge.)
To me there is nothing to do, unless provided otherwise.

These decorators don't need to implement reset interface, unless they're used asservice decorators (they're not to my knownledge.) To me there is nothing to do, unless provided otherwise.

Allright, closing this PR and preparing another with implemented ResetInterface for http clients

Thanks. I submitted#43983 and#43981. They should help on the topic also.