Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Loco] Fix Loco Provider ID and pull & push local messages reading#43967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabpot commentedNov 8, 2021
Thank you@welcoMattic. |
welcoMattic commentedNov 8, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@fabpot I just realized that I opened this PR on 5.4 instead of 5.3, since it is a bugfix. Sorry |
| foreach ($keysas$key) { | ||
| $responses[$key] =$this->client->request('POST','assets', [ | ||
| 'body' => [ | ||
| 'id' =>$key, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
be careful. Translation keys are only unique per domain, not globally. so they might note be suitable as loco ids.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are right, so may be we can concatenate the domain as prefix or suffix to the key?
Uh oh!
There was an error while loading.Please reload this page.
It fixes Loco push new messages and avoiding Loco auto-generation of ID for each new messages (which use dash notation instead of dot notation IIRC).
And it fixes also the Translation push & pull commands when they read local messages for multiple domains.