Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Fix logic in workflow:dump between workflow name and workflow id#43940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4from94noni:fx-workflow-dump
Nov 5, 2021

Conversation

@94noni
Copy link
Contributor

@94noni94noni commentedNov 5, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#43938
LicenseMIT

As described in#43938 (comment)
the command need a workflow name as argument, but the array contains workflows ids (prefixworkflow|state_machine)

Copy link
Contributor

@StaffNowaStaffNowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for fix ;)

@noniagriconomie
Copy link
Contributor

@StaffNowa really my bad maybe wrong explanation on your PR!
conflicts between the workflow name pass as argument and the workflows ids passed in constructor :)

StaffNowa reacted with thumbs up emoji

Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fabpot
Copy link
Member

Thank you@94noni.

@fabpotfabpot merged commit8a9e826 intosymfony:5.4Nov 5, 2021
@94noni94noni deleted the fx-workflow-dump branchNovember 6, 2021 10:36
This was referencedNov 14, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lyrixxlyrixxlyrixx approved these changes

+1 more reviewer

@StaffNowaStaffNowaStaffNowa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Workflow] Command workflow:dump not working

6 participants

@94noni@noniagriconomie@fabpot@lyrixx@StaffNowa@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp