Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Console] Open CompleteCommand for custom outputs#43923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@wouterj
Copy link
Member

@wouterjwouterj commentedNov 3, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
Tickets-instead -->
LicenseMIT
Doc PR-

Having this feature in 5.4 is especially great, as it will allow Composer 2.2 to use this feature as well.

If we in the future add fish or zsh support, it would be very cool if these can be "backported" by Composer. Keeping the$completionOutputs property closed would permit this, while this little change opens up adding custom output supports outside the Symfony source code.

@GromNaN
Copy link
Member

You should add a test, right?

wouterj reacted with thumbs up emoji

@wouterjwouterjforce-pushed thefeature/console-completion-forward branch frombd2cad0 tod3e4574CompareNovember 4, 2021 11:49
@wouterj
Copy link
MemberAuthor

wouterj commentedNov 4, 2021•
edited
Loading

Thanks for the reviews. All should be fixed now.

status: needs review

@fabpot
Copy link
Member

Can you fix the tests? The output has changed a bit.

@wouterjwouterjforce-pushed thefeature/console-completion-forward branch fromd3e4574 to1f58312CompareNovember 4, 2021 12:16
@wouterj
Copy link
MemberAuthor

Ooh, not again 😣 . Should be green now

@fabpot
Copy link
Member

Thank you@wouterj.

@fabpotfabpot merged commit0abd898 intosymfony:5.4Nov 4, 2021
@wouterjwouterj deleted the feature/console-completion-forward branchNovember 4, 2021 12:32
@stof
Copy link
Member

stof commentedNov 4, 2021

@wouterj as we now make the CompletionOutputInterface an extension point where third-party code can register their own implementation, I think we need to add the constructor with no argument in the interface, to enforce that signature (as the instantiation is done in the CompleteCommand

This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@wouterj@GromNaN@fabpot@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp