Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[5.4][WebProfiler] Fixing missing full_stack variable that's needed by toolbar.html.twig#43914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromweaverryan:fix-full_stack_variable
Nov 3, 2021

Conversation

@weaverryan
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsNone
LicenseMIT
Doc PRNot needed

The combination of#43526 and then#41257 created an undefined variable. By adding the variable here, it will flow fromtoolbar_js.html.twig intotoolbar.html.twig.

Tested locally after reproducing the issue. Thanks to symfony/ux test suite for catching this :)

@fabpot
Copy link
Member

Thank you@weaverryan.

@fabpotfabpot merged commitd254e8d intosymfony:5.4Nov 3, 2021
@weaverryanweaverryan deleted the fix-full_stack_variable branchNovember 3, 2021 15:20
@DesLynx
Copy link

DesLynx commentedNov 4, 2021•
edited
Loading

Hi@fabpot !
It seems that this bugfix from@weaverryan hasn't reach the5.4 branch of symfony/web-profiler-bundle yet.
Do you plan to push it or are you still looking into it?

@stof
Copy link
Member

stof commentedNov 4, 2021

@DesLynx there is an issue under investigation with the splitter tooling.

@DesLynx
Copy link

All right. Well, thanks for the heads up@stof

@fabpot
Copy link
Member

Fixed now

DesLynx reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@weaverryan@fabpot@DesLynx@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp