Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Add completion to command messenger:consume#43891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromGromNaN:completion/messenger-consume
Nov 3, 2021

Conversation

@GromNaN
Copy link
Member

@GromNaNGromNaN commentedNov 2, 2021•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets#43594
LicenseMIT
Doc PR-

Commandmessenger:consume takes a list ofreceivers that should be unique. The values for option--bus where easy to inject into the command.

I skipped the option--queue whose values are defined deep in the transport options.

@fabpot
Copy link
Member

@GromNaN Can you have a look at the tests, they seem broken by this PR.

GromNaN reacted with thumbs up emoji

@GromNaNGromNaNforce-pushed thecompletion/messenger-consume branch from9d2f912 toc3327b7CompareNovember 3, 2021 12:36
@GromNaNGromNaNforce-pushed thecompletion/messenger-consume branch 2 times, most recently from799c274 to5adc94dCompareNovember 3, 2021 13:28
@GromNaNGromNaNforce-pushed thecompletion/messenger-consume branch from5adc94d tof99f586CompareNovember 3, 2021 13:35
@GromNaN
Copy link
MemberAuthor

Tests are green@fabpot.

@fabpot
Copy link
Member

Thank you@GromNaN.

@fabpotfabpot merged commit0828a91 intosymfony:5.4Nov 3, 2021
@GromNaNGromNaN deleted the completion/messenger-consume branchNovember 3, 2021 14:59
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@srozesrozeAwaiting requested review from sroze

+1 more reviewer

@stloydstloydstloyd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@GromNaN@fabpot@stloyd@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp