This looks strange to me because this means that['http://☎a'] is a valid domain name, while['http://☎'] is invalid...

This looks strange to me because this means that['http://☎a'] is a valid domain name, while['http://☎'] is invalid...

@nicolas-grekas wasn't this case fixed by#44119?

#44119 is on HttpClient+Mime, this one is on Validator, so I'm not sure.

Yes you are right, at the Validator level maybe we don't have to worry about thexn-- URL format?
If so, your concern is still legitimate

@nicolas-grekas Sorry, I missed your earlier comment, will check it out later today.

Looks like#44252 could provide us with another test case, can you please incorporate it here also?

I've split the domain part into two cases:

1. single-level domain, the assumption here is that since there's no TLD, it's an internal domain, allows symbols, hyphens etc..
2. multi-level domain, has a TLD. Since I haven't been able to find any clear information on which characters are allowed in a TLD I went with hyphens allowed, but not at the end, no symbols

Of course, this won't work if you have a multi-level internal domain, egsubdomain.internal☎. Any suggestions would be appreciated.

Thank you@HypeMC.