NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[RateLimiter] Increase delta in limiter tests#43847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.3fromwkania-forks:bugfix/increase-delta-in-limiter-tests

Nov 1, 2021

Merged

[RateLimiter] Increase delta in limiter tests#43847

fabpot merged 1 commit intosymfony:5.3fromwkania-forks:bugfix/increase-delta-in-limiter-tests

Nov 1, 2021

Conversation

Copy link

Contributor

wkania commentedOct 30, 2021•
edited
Loading

Q	A
Branch?	5.3
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

Tests fromPR might randomly fail1 2

I increased delta like inthis test.

@fabpot @Nyholm please review

[RateLimiter] Increase delta in limiter tests

3e2ca33

carsonbot added Status: Needs Review Bug RateLimiter labels

Oct 30, 2021

carsonbot added this to the5.3 milestone

Oct 30, 2021

Copy link

carsonbot commentedOct 30, 2021

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot