Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add completion for debug:twig#43846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromStaffNowa:feature/debug-twig
Nov 1, 2021
Merged

Add completion for debug:twig#43846

fabpot merged 1 commit intosymfony:5.4fromStaffNowa:feature/debug-twig
Nov 1, 2021

Conversation

@StaffNowa
Copy link
Contributor

QA
Branch?5.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets#43594
LicenseMIT
Doc PR-

Add completion for debug:twig

@StaffNowa
Copy link
ContributorAuthor

StaffNowa commentedNov 1, 2021•
edited
Loading

@fabpot disabled IDE and tried to clean my code.
Fabbot not happy
image

@fabpot
Copy link
Member

You can ignore fabbot :)

StaffNowa reacted with eyes emoji

@StaffNowa
Copy link
ContributorAuthor

You can ignore fabbot :)

OK 🤣

Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the PR!

I've added a couple comments, seems like you missed some things while applying some of Fabien's comments :) If this is fixed, it should be ready to go imho

@wouterjwouterj mentioned this pull requestNov 1, 2021
54 tasks
@StaffNowa
Copy link
ContributorAuthor

@wouterj thanks for code review. I missed that we have two methods for execute() displayGeneralText() and displayGeneralJson()

wouterj reacted with thumbs up emoji

Comment on lines 603 to 610
$names = [];
$paths =$this->getLoaderPaths();

foreach ($pathsas$namespace =>$paths) {
$names[] =$namespace;
}

return$names;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This can be replaced witharray_keys($this->getLoaderPaths()) (and can be inlined on line 118 directly)


privatefunctiongetAvailableFormatOptions():array
{
return ['text','json'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can be inlined as well

@StaffNowa
Copy link
ContributorAuthor

@wouterj thanks optimized code :)

@fabpot
Copy link
Member

Thank you@StaffNowa.

@fabpotfabpot merged commitf377018 intosymfony:5.4Nov 1, 2021
@StaffNowaStaffNowa deleted the feature/debug-twig branchNovember 1, 2021 14:46
This was referencedNov 5, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@wouterjwouterjwouterj approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@StaffNowa@fabpot@wouterj@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp