NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

feat: add completion for DebugAutowiring search argument#43838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.4fromeclairia:feature-debug-completion

Nov 4, 2021

Merged

feat: add completion for DebugAutowiring search argument#43838

fabpot merged 1 commit intosymfony:5.4fromeclairia:feature-debug-completion

Nov 4, 2021

Conversation

Copy link

Contributor

eclairia commentedOct 30, 2021•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	#43594
License	MIT
Doc PR	-

Adding Bash completion debug:autowiring command.

carsonbot added Status: Needs Review Feature labels

Oct 30, 2021

carsonbot added this to the5.4 milestone

Oct 30, 2021

Copy link

carsonbot commentedOct 30, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

eclairia force-pushed thefeature-debug-completion branch from0ebd8e8 to2ab8199Compare

October 30, 2021 12:30

GromNaN requested changes

Oct 30, 2021

View reviewed changes

Copy link

Member

GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@eclairia. Here is an opinionated feedback.

src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php Outdated


		$searchNormalized =$this->getSearchNormalized($input->getArgument('search'));

		$serviceIds =array_filter($serviceIds,function ($serviceId)use ($searchNormalized) {

Copy link

Member

GromNaNOct 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the class names (service IDs) don't need to be normalized for completion. Suggestions would be identical to defined service IDs.

Copy link

ContributorAuthor

eclairiaOct 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you@GromNaN for the review.

I removed the completion normalization for class names.
I also added the class alias into the completion since the search argument can also take an alias in value.