Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Inflector] Fix inflector for "zombies"#43834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:4.4fromacodispo:ticket_43789_symf4
Oct 29, 2021

Conversation

@acodispo
Copy link
Contributor

The word "zombies" should be singularized to "zombie" (rather than
"zomby"). We provide a PLURAL_MAP for this case, as well as a test.

QA
Branch?4.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsSee#43789
LicenseMIT

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

The word "zombies" should be singularized to "zombie" (rather than"zomby"). We provide a PLURAL_MAP for this case, as well as a test.
@fabpot
Copy link
Member

Thank you@acodispo.

acodispo reacted with thumbs up emoji

@fabpotfabpot merged commita9b5383 intosymfony:4.4Oct 29, 2021
@wkania
Copy link
Contributor

@fabpot This apparently causedPHP 8 CI to fail on branch 5.4

@derrabus
Copy link
Member

@wkania see#43842

wkania reacted with eyes emoji

@acodispoacodispo deleted the ticket_43789_symf4 branchOctober 30, 2021 20:35
This was referencedNov 22, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

5 participants

@acodispo@carsonbot@fabpot@wkania@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp