Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Runtime] Consider also $_ENV when resolving APP_RUNTIME and APP_RUNTIME_OPTIONS#43833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedOct 29, 2021
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
CHANGELOG-5.3.md Outdated
| * feature#38998[Messenger][SQS] Make sure one can enable debug logs (Nyholm) | ||
| * feature#38974[Intl] deprecate polyfills in favor of symfony/polyfill-intl-icu (nicolas-grekas) | ||
| * feature#43832[Runtime] consider also $_ENV when resolving APP_RUNTIME and APP_RUNTIME_OPTIONS (peter-si) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please remove this line: this file is autogenerated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh ok. Might I suggest to change the PR template? Since it says| New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
the file you changed is not under src/ ;)
that's fine, it's your first contribution, we're here to help :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
true that...It got me confused :) Thanks, it is reverted.
nicolas-grekas commentedOct 29, 2021
Thank you@peter-si. |
Uh oh!
There was an error while loading.Please reload this page.
Take also $_ENV into consideration when resolving APP_RUNTIME and APP_RUNTIME_OPTIONS.
On docker apache containers to get env variable into $_SERVER other configuration steps are needed. This is unnecessary since they are already available in $_ENV. Or maybe we can use getenv()? I'm preparing a PR for it (will be done in a bit)