Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Update the ICU data to 70.1 - 5.3#43814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7bab272 toe17639bCompare| ], | ||
| 'LSL' => [ | ||
| 0 =>'LSL', | ||
| 1 =>'This is not a translation', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks like the ICU release contains a weird thing here...
| 'BRB' =>76, | ||
| 'BRC' =>76, | ||
| 'BRE' =>76, | ||
| 'BRN' =>76, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
would be great to make this array deterministic, to avoid shuffling in between updates (looks like it is sorted by value, but values are not unique)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
do we care about diff in generated data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Well, we removed the ICU version from all those generated files precisely to reduce meaningless diffs.
fabpot commentedNov 4, 2021
Thank you@jderusse. |
This PR is dedicated to 5.3 because we switch from .json file to .PHP file