Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
drop support for configuring Symfony with Composer 1#43813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedOct 29, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
| { | ||
| if (!class_exists(InstalledVersions::class)) { | ||
| trigger_deprecation('symfony/framework-bundle','5.4','Configuring Symfony without theComposer Runtime API isdeprecated. Consider upgrading to Composer 2.'); | ||
| thrownewLogicException('TheComposer Runtime API isrequired to configure Symfony. Consider upgrading to Composer 2.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As now it throws ex, maybe the wordConsider is no more appropriate, but moreYou must upgrade no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we usually use "should", so "consider" is fine to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be done using requirements oncomposer-runtime-api in the composer.json, which will then mean that this exception is never triggered...
1dfb031 to3f1d476Comparexabbuh commentedOct 29, 2021
I missed that we already have#43788 for this |