Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[TwigBundle] fix asset package availability detection#43791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Nek- wants to merge1 commit intosymfony:5.3fromNek-:fix/asset-package-detection

Conversation

@Nek-
Copy link
Contributor

QA
Branch?5.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#41672
LicenseMIT

This is an attempt tofix#41672 . It actually fixes it for the asset package. I've no idea if there are other impacts and how to reproduce them.

If the package assets is available in the dependencies, Symfony willenable automatically assets. Otherwise assets are disabled. The problemis that sometimes you want to explicetely enable assets features (in thecase of testing an application you may have assets as **dev**dependency).In the case assets are enable explicitely, the service assets.packagesis defined and we should not remove the definitiontwig.extension.assets.
@Nek-Nek- requested a review fromyceruto as acode ownerOctober 27, 2021 18:28
@carsonbotcarsonbot added this to the5.3 milestoneOct 27, 2021
@Nek-Nek- changed the titlefeat: fix asset package availability detection[TwigBundle] fix asset package availability detectionOct 28, 2021
@nicolas-grekas
Copy link
Member

Closing in favor of#43801, thanks for providing more insights on the topic!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Nek-@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp