NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[String] Fix inflector for "zombies"#43790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:5.3fromacodispo:ticket_43789

Oct 28, 2021

Merged

[String] Fix inflector for "zombies"#43790

fabpot merged 1 commit intosymfony:5.3fromacodispo:ticket_43789

Oct 28, 2021

Conversation

Copy link

Contributor

acodispo commentedOct 27, 2021

The word "zombies" should be singularized to "zombie" (rather than
"zomby"). We provide a PLURAL_MAP for this case, as well as a test.

Q	A
Branch?	5.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#43789
License	MIT

[String] Add PLURAL_MAP "zombies" --fixsymfony#43789

46c63eb

The word "zombies" should be singularized to "zombie" (rather than"zomby"). We provide a PLURAL_MAP for this case, as well as a test.

carsonbot added Status: Needs Review Bug String labels

Oct 27, 2021

carsonbot added this to the5.3 milestone

Oct 27, 2021

Copy link

carsonbot commentedOct 27, 2021

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedOct 27, 2021

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot